Adds support for custom Security Group rules #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Aug 4, 2021
main.tf
Outdated
Comment on lines
78
to
85
| rules = [ | ||
| { | ||
| type = "ingress" | ||
| from_port = 22 | ||
| to_port = 22 | ||
| protocol = "tcp" | ||
| cidr_blocks = var.allowed_cidrs | ||
| } |
There was a problem hiding this comment.
Nono, this goes against the spirit of the module. The objective is to expsoe the rules variable so the caller has unfettered ability to add rules for ingress/egress.
bradj
changed the title
Benbentwo
reviewed
Aug 5, 2021
variables.tf
Outdated
| from_port = 22 | ||
| to_port = 22 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["10.0.0.0/16"] |
There was a problem hiding this comment.
should this be an empty array by default?
There was a problem hiding this comment.
@Benbentwo I copied the pattern from this repo.
It also has the cidr_block array populated with 0.0.0.0/0 but I don't like having it open to the world so leaving cidr_block with [] will show an error explaining it needs to be set. Not the greatest UX unfortunately but I think security should take precedence over UX. Unless there's a better way.
Benbentwo
reviewed
Aug 5, 2021
|
|
||
| variable "security_group_rules" { | ||
| type = list(any) | ||
| default = [ |
There was a problem hiding this comment.
or this be an empty array by default?
Benbentwo
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references