Partition and restrict S3 paths across SFTP users #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Aug 7, 2021
variables.tf
Outdated
| @@ -14,6 +14,12 @@ variable "sftp_users" { | |||
| description = "List of SFTP usernames and public keys" | |||
| } | |||
|
|
|||
| variable "sftp_restricted" { | |||
There was a problem hiding this comment.
home_directory_type would keep it consistent with the argument.
There was a problem hiding this comment.
I'm leaning towards restricted_home because home_directory_type on the aws_transfer_user resource doesn't entirely control whether or not the user will be restricted to their home directory.
nitrocode
reviewed
Aug 8, 2021
main.tf
Outdated
|
|
||
| name = module.iam_label.id | ||
| policy = join("", data.aws_iam_policy_document.allows_s3[*].json) | ||
| name = "${module.iam_label.id}-${each.value}" |
There was a problem hiding this comment.
Shouldn't this use a separate label module reference in case someone changes the delimiter?
There was a problem hiding this comment.
It would also be OK to replace the - with ${module.iam_label.delimiter}, but a new label module is better because it will also handle case conversion and forbidden character removal on each.value.
nitrocode
reviewed
Aug 8, 2021
nitrocode
reviewed
Aug 8, 2021
nitrocode
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references