Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error in example #107

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Fix syntax error in example #107

merged 4 commits into from
Aug 3, 2022

Conversation

vanastassiou
Copy link
Contributor

Fixes a syntax error in the "Full example with terraform-aws-dynamic-subnets" code that results in a terraform plan failure.

what

  • The example presented with dynamic-subnets generates a syntax error during terraform plan

why

  • Improves documentation reliability

@vanastassiou
Update README.md
b901dd8 
Fix syntax error that causes plan to fail
@vanastassiou vanastassiou requested review from a team as code owners July 27, 2022 20:20
@vanastassiou vanastassiou requested review from Gowiem and woz5999 and removed request for a team July 27, 2022 20:20
@vanastassiou
Copy link
Contributor Author

Hilariously, @cloudpossebot reverted my fix in the Auto Format step.

@joe-niland
Copy link
Member

Hi @vanastassiou if you reapply it to readme.yaml it should work.

@vanastassiou
Copy link
Contributor Author

Thanks @joe-niland, I've pushed that change.

@joe-niland
Copy link
Member

/test all

@joe-niland joe-niland added the patch A minor, backward compatible change label Aug 3, 2022
@joe-niland joe-niland self-requested a review August 3, 2022 04:45
@joe-niland joe-niland merged commit cd5c6b0 into cloudposse:master Aug 3, 2022
@joe-niland
Copy link
Member

Thanks @vanastassiou - released as https://github.com/cloudposse/terraform-aws-vpc/releases/tag/1.1.1

@vanastassiou vanastassiou deleted the fix-example-syntax branch August 3, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-niland joe-niland joe-niland approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanastassiou @joe-niland @cloudpossebot