Drop support for deprecated features, revamp VPC Endpoint support #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuru
added
the
no-release
Nuru
requested review from
joe-niland and
RothAndrew
and removed request for
a team
|
/test all |
Benbentwo
approved these changes
Oct 5, 2022
|
|
||
| You will need to add `route_table_ids` to `gateway_vpc_endpoints`, but it can be an empty list. | ||
|
|
||
| Terraform plan may show changes, but they should not have any effect. |
There was a problem hiding this comment.
this line is somewhat concerning Should not have any effect
aknysh
reviewed
Oct 5, 2022
| @@ -19,11 +19,11 @@ output "vpc_id" { | |||
| } | |||
|
|
|||
| output "gateway_vpc_endpoints" { | |||
| value = module.vpc_endpoints.gateway_vpc_endpoints | |||
| value = module.vpc_endpoints.gateway_vpc_endpoints_map | |||
| description = "List of Gateway VPC Endpoints deployed to the VPC." | |||
| } | |||
There was a problem hiding this comment.
I'd update the description to
description = "Gateway VPC Endpoints deployed to the VPC."
but we can do it in a follow up OR since we have to update this anyway
source = "cloudposse/security-group/aws"
version = "2.0.0-rc1"
aknysh
reviewed
Oct 5, 2022
| description = "List of Gateway VPC Endpoints deployed to the VPC." | ||
| } | ||
|
|
||
| output "interface_vpc_endpoints" { | ||
| value = module.vpc_endpoints.interface_vpc_endpoints | ||
| value = module.vpc_endpoints.interface_vpc_endpoints_map | ||
| description = "List of Interface VPC Endpoints deployed to the VPC." |
There was a problem hiding this comment.
description = "Interface VPC Endpoints deployed to the VPC."
aknysh
reviewed
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This will be released as version 2.0.0-rc1 and possibly as 2.0.0 without changes.
See migration notes for details.
what
modules/vpc-endpoints)why
references