Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new module, documentation, and complete example #1

Merged
merged 46 commits into from
Oct 13, 2020

Conversation

danjbh
Copy link
Contributor

@danjbh danjbh commented Oct 8, 2020

what

  • All changes associated w/ the new module

why

  • This module automates the deployment of the Terraform Cloud Agent to an existing Kubernetes cluster

@danjbh danjbh requested a review from osterman October 8, 2020 18:52
@danjbh danjbh marked this pull request as ready for review October 8, 2020 18:52
README.yaml Outdated Show resolved Hide resolved
README.yaml Outdated Show resolved Hide resolved
README.yaml Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@danjbh
Copy link
Contributor Author

danjbh commented Oct 9, 2020

hey @osterman I made the rest of the updates and tested everything, although there's one more item I'd like to inquire about..

Do you think that the TCF_AGENT_TOKEN should be considered "sensitive" and stored/accessed via a k8s secret?

@osterman
Copy link
Member

osterman commented Oct 9, 2020

Do you think that the TCF_AGENT_TOKEN should be considered "sensitive" and stored/accessed via a k8s secret?

I suppose you're right. It's sensitive because any agent with that can receive dispatches from TFE/TFC and those dispatches could contain secrets. It's probably not too much more work and for correctness should be a Secret

main.tf Outdated Show resolved Hide resolved
outputs.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@osterman
Copy link
Member

osterman commented Oct 9, 2020

Maybe this module should be called terraform-kubernetes-tfc-cloud-agent instead since HashiCorp never seems to refer to it as TFE (Even though TFE/business is required)

@danjbh
Copy link
Contributor Author

danjbh commented Oct 13, 2020

Hey @osterman , I forgot to send a note late last week, but all of the changes to this one were made and its ready for final review 👍

README.yaml Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
@danjbh
Copy link
Contributor Author

danjbh commented Oct 13, 2020

Ok all fixed @osterman 👍

main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
danjbh and others added 5 commits October 13, 2020 12:04
Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Erik Osterman <erik@cloudposse.com>
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@osterman osterman merged commit 6d60cb6 into master Oct 13, 2020
@osterman osterman deleted the initial-draft branch October 13, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants