Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridgecrew compliance #125

Merged
merged 3 commits into from
Feb 7, 2021
Merged

Bridgecrew compliance #125

merged 3 commits into from
Feb 7, 2021

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Feb 6, 2021

what

  • Resolve Bridgecrew compliance complaint about example Autoscaling Group (BC_AWS_GENERAL_31)
  • Fix typo in README
  • Include Terraform lock file in .gitignore

why

  • Get clean Bridgecrew badge
  • Correct confusing error
  • Ensure lock files are not checked into GitHub

note

The PR can and should be merged into master to update README and Bridgecrew without triggering a new release/version. These changes have no effect on the actual module in use and a release will create unnecessary ripple effects. However, merging to master will update the README and badges, so is worthwhile, and the changes will move forward into the next release.

@Nuru Nuru requested review from osterman and maximmi February 6, 2021 23:01
@Nuru Nuru requested a review from a team as a code owner February 6, 2021 23:01
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Feb 6, 2021

/test all

osterman
osterman previously approved these changes Feb 6, 2021
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Feb 6, 2021

/test all

@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Feb 6, 2021

/test all

@Nuru Nuru requested a review from osterman February 6, 2021 23:36
@Nuru Nuru merged commit cf38625 into master Feb 7, 2021
@Nuru Nuru deleted the bc-compliance branch February 7, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants