Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly output descriptors of chained modules #133

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Properly output descriptors of chained modules #133

merged 1 commit into from
Aug 25, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Aug 25, 2021

what

  • Properly output descriptors of chained modules

why

  • Bug fix; implement intended behavior

@Nuru Nuru added the bugfix Change that restores intended behavior label Aug 25, 2021
@Nuru Nuru requested review from aknysh and korenyoni August 25, 2021 06:53
@Nuru Nuru requested a review from a team as a code owner August 25, 2021 06:53
@Nuru
Copy link
Contributor Author

Nuru commented Aug 25, 2021

/test all

korenyoni
korenyoni approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for getting this fix out.

@Nuru Nuru merged commit 488ab91 into master Aug 25, 2021
@Nuru Nuru deleted the chain branch August 25, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@aknysh aknysh aknysh approved these changes

@korenyoni korenyoni korenyoni approved these changes

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nuru @osterman @aknysh @korenyoni