Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix pagination bug #35

Merged
merged 1 commit into from
Aug 30, 2022
Merged

bug: fix pagination bug #35

merged 1 commit into from
Aug 30, 2022

Conversation

mcalhoun
Copy link
Member

@mcalhoun mcalhoun commented Aug 30, 2022 •
edited by aknysh
Loading

what

  • Fix a bug with pagination when calling the Security Hub DescribeStandardsControls API method.

why

  • Previously we were not using pagination and this created a scenario where the control we were searching for might not be found depending on the number of controls enabled on the account.

references

@mcalhoun mcalhoun requested review from a team as code owners August 30, 2022 02:58
@mcalhoun mcalhoun merged commit ffe99d0 into main Aug 30, 2022
@mcalhoun mcalhoun deleted the bug/fix-issue-with-pagination branch August 30, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcalhoun @aknysh