Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cloud Posse's Utils provider to deep merge #19

Merged
merged 22 commits into from
Apr 21, 2022
Merged

Use Cloud Posse's Utils provider to deep merge #19

merged 22 commits into from
Apr 21, 2022

Conversation

Benbentwo
Copy link
Member

@Benbentwo Benbentwo commented Apr 19, 2022 •
edited
Loading

what

  • Uses Cloudposse Utils Provider to allow deepmerges

why

  • Need a way to merge with merging lists (exposed via append_list variable)

@Benbentwo Benbentwo requested review from a team as code owners April 19, 2022 20:11
@osterman osterman changed the title feature cloudposse provider deep merge Use Cloud Posse's Utils provider to deep merge Apr 19, 2022
@nitrocode
Copy link
Member

/test all

@Benbentwo
Copy link
Member Author

/test all

@Benbentwo
Copy link
Member Author

/test all

osterman
osterman previously approved these changes Apr 21, 2022
View reviewed changes
@Benbentwo Benbentwo added the major Breaking changes (or first stable release) label Apr 21, 2022
nitrocode
nitrocode previously approved these changes Apr 21, 2022
View reviewed changes
@nitrocode
Copy link
Member

/test all

aknysh
aknysh reviewed Apr 21, 2022
View reviewed changes
modules/yaml-config/main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Apr 21, 2022
View reviewed changes
modules/yaml-config/main.tf Outdated Show resolved Hide resolved
aknysh
aknysh requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Benbentwo please see comments

@Benbentwo Benbentwo dismissed stale reviews from nitrocode and osterman via e6da036 April 21, 2022 20:03
@Benbentwo
Copy link
Member Author

/test all

@Benbentwo Benbentwo merged commit 98287f8 into main Apr 21, 2022
@Benbentwo Benbentwo deleted the feature/deep-merge branch April 21, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni left review comments

@aknysh aknysh aknysh approved these changes

@nitrocode nitrocode nitrocode left review comments

@osterman osterman osterman left review comments

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Benbentwo @nitrocode @osterman @aknysh @korenyoni @cloudpossebot