Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix(tests): Remove terraform for Azure ExpressRoute port #440

Merged
merged 2 commits into from
Jul 29, 2022
Merged

fix(tests): Remove terraform for Azure ExpressRoute port #440

merged 2 commits into from
Jul 29, 2022

Conversation

hermanschaaf
Copy link
Member

@hermanschaaf hermanschaaf commented Jul 29, 2022 •
edited
Loading

This was costing ~6k per month, and the terraform resource doesn't allow us to use the lowest bandwidth setting of 50mbps, since it has to be specified in whole-number gbps

@hermanschaaf
fix(tests): remove terraform for Azure ExpressRoute port
dec6f73 
This was costing ~k per month, and the terraform resource doesn't allow us to use the lowest bandwidth setting of 50mbps, since it has to be specified in whole-number gbps
@hermanschaaf hermanschaaf requested a review from a team as a code owner July 29, 2022 13:29
@hermanschaaf hermanschaaf requested review from bbernays and removed request for a team July 29, 2022 13:29
@github-actions
Copy link

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output 

Success! The configuration is valid.

Terraform Plan success

Show Plan 

module.demo.azurerm_resource_group.network: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg]
module.demo.azurerm_express_route_port.er_port: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/expressRoutePorts/cq-er-port]
module.demo.azurerm_local_network_gateway.onpremise: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/localNetworkGateways/onpremise]
module.demo.azurerm_express_route_circuit.er_circuit: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/expressRouteCircuits/cq-circuit]
module.demo.azurerm_virtual_wan.virtual_wan: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualWans/cq-er-virtualwan]
module.demo.azurerm_public_ip.example: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/publicIPAddresses/cq-virtual-network-gateway-public-ip]
module.demo.azurerm_virtual_network.example: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualNetworks/cq-vnet-example]
module.demo.azurerm_route_filter.route_filter: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/routeFilters/cq-route-filter]
module.demo.azurerm_virtual_hub.virtual_hub: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualHubs/cq-er-virtualhub]
module.demo.azurerm_subnet.example: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualNetworks/cq-vnet-example/subnets/GatewaySubnet]
module.demo.azurerm_express_route_gateway.gateway: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/expressRouteGateways/cq-er-gateway]
module.demo.azurerm_virtual_network_gateway.example: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualNetworkGateways/cq-er-virtual-network-gateway]
module.demo.azurerm_virtual_network_gateway_connection.onpremise: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/connections/cq-er-virtual-network-gateway-connection]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Pusher: @hermanschaaf, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

@github-actions
Copy link

💰 Infracost estimate: monthly cost will not change

Project Previous New Diff
cloudquery/cq-provider-azure/terraform/network/prod/plan.json $336 $336 $0
Infracost output 
──────────────────────────────────

The following projects have no cost estimate changes: cloudquery/cq-provider-azure/terraform/network/prod/plan.json
Run the following command to see their breakdown: infracost breakdown --path=/path/to/code

──────────────────────────────────
13 cloud resources were detected:
∙ 3 were estimated, 1 of which usage-based costs, see https://infracost.io/usage-file
∙ 7 were free:
  ∙ 1 x azurerm_local_network_gateway
  ∙ 1 x azurerm_resource_group
  ∙ 1 x azurerm_subnet
  ∙ 1 x azurerm_virtual_hub
  ∙ 1 x azurerm_virtual_network
  ∙ 1 x azurerm_virtual_network_gateway_connection
  ∙ 1 x azurerm_virtual_wan
∙ 3 are not supported yet, see https://infracost.io/requested-resources:
  ∙ 1 x azurerm_express_route_circuit
  ∙ 1 x azurerm_express_route_port
  ∙ 1 x azurerm_route_filter

This comment will be updated when the cost estimate changes.

Is this comment useful? Yes, No, Other

@github-actions
Copy link

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output 

Success! The configuration is valid.

Terraform Plan success

Show Plan 

module.demo.azurerm_resource_group.network: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg]
module.demo.azurerm_express_route_port.er_port: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/expressRoutePorts/cq-er-port]
module.demo.azurerm_route_filter.route_filter: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/routeFilters/cq-route-filter]
module.demo.azurerm_public_ip.example: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/publicIPAddresses/cq-virtual-network-gateway-public-ip]
module.demo.azurerm_express_route_circuit.er_circuit: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/expressRouteCircuits/cq-circuit]
module.demo.azurerm_virtual_network.example: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualNetworks/cq-vnet-example]
module.demo.azurerm_virtual_wan.virtual_wan: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualWans/cq-er-virtualwan]
module.demo.azurerm_local_network_gateway.onpremise: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/localNetworkGateways/onpremise]
module.demo.azurerm_subnet.example: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualNetworks/cq-vnet-example/subnets/GatewaySubnet]
module.demo.azurerm_virtual_hub.virtual_hub: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualHubs/cq-er-virtualhub]
module.demo.azurerm_virtual_network_gateway.example: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/virtualNetworkGateways/cq-er-virtual-network-gateway]
module.demo.azurerm_express_route_gateway.gateway: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/expressRouteGateways/cq-er-gateway]
module.demo.azurerm_virtual_network_gateway_connection.onpremise: Refreshing state... [id=/subscriptions/78f26f10-0e60-4293-8a7e-122584ccb40d/resourceGroups/cq-network-rg/providers/Microsoft.Network/connections/cq-er-virtual-network-gateway-connection]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Pusher: @hermanschaaf, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

@hermanschaaf hermanschaaf changed the title fix(tests): remove terraform for Azure ExpressRoute port fix(tests): Remove terraform for Azure ExpressRoute port Jul 29, 2022
@hermanschaaf hermanschaaf merged commit 7413740 into cloudquery:main Jul 29, 2022
@cq-bot cq-bot mentioned this pull request Jul 29, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 7, 2022
@cq-bot
chore(main): Release v0.12.3 (#441)
46463bb 
🤖 I have created a release *beep* *boop*
---


## [0.12.3](v0.12.2...v0.12.3) (2022-08-07)


### Features

* Add support for Tenants ([#412](#412)) ([940af7f](940af7f))


### Bug Fixes

* **deps:** Update module github.com/Azure/go-autorest/autorest to v0.11.28 ([#443](#443)) ([bc87594](bc87594))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.7 ([#453](#453)) ([361d908](361d908))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.8 ([#457](#457)) ([7d61851](7d61851))
* **deps:** Update module github.com/hashicorp/go-hclog to v1.2.2 ([#444](#444)) ([6c769c9](6c769c9))
* **deps:** Update tubone24/update_release digest to 2146f15 ([#389](#389)) ([e5682fd](e5682fd))
* **docs:** Some minor docs fixes ([#454](#454)) ([6feb015](6feb015))
* **tests:** Remove terraform for Azure ExpressRoute port ([#440](#440)) ([7413740](7413740))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit to cloudquery/cloudquery that referenced this pull request Aug 14, 2022
@cq-bot
chore(main): Release v0.12.3 (#441)
8323a8e 
🤖 I have created a release *beep* *boop*
---


## [0.12.3](cloudquery/cq-provider-azure@v0.12.2...v0.12.3) (2022-08-07)


### Features

* Add support for Tenants ([#412](cloudquery/cq-provider-azure#412)) ([940af7f](cloudquery/cq-provider-azure@940af7f))


### Bug Fixes

* **deps:** Update module github.com/Azure/go-autorest/autorest to v0.11.28 ([#443](cloudquery/cq-provider-azure#443)) ([bc87594](cloudquery/cq-provider-azure@bc87594))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.7 ([#453](cloudquery/cq-provider-azure#453)) ([361d908](cloudquery/cq-provider-azure@361d908))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.8 ([#457](cloudquery/cq-provider-azure#457)) ([7d61851](cloudquery/cq-provider-azure@7d61851))
* **deps:** Update module github.com/hashicorp/go-hclog to v1.2.2 ([#444](cloudquery/cq-provider-azure#444)) ([6c769c9](cloudquery/cq-provider-azure@6c769c9))
* **deps:** Update tubone24/update_release digest to 2146f15 ([#389](cloudquery/cq-provider-azure#389)) ([e5682fd](cloudquery/cq-provider-azure@e5682fd))
* **docs:** Some minor docs fixes ([#454](cloudquery/cq-provider-azure#454)) ([6feb015](cloudquery/cq-provider-azure@6feb015))
* **tests:** Remove terraform for Azure ExpressRoute port ([#440](cloudquery/cq-provider-azure#440)) ([7413740](cloudquery/cq-provider-azure@7413740))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbernays bbernays bbernays approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hermanschaaf @bbernays