Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add --license placeholder for future use #108

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

disq
Copy link
Member

@disq disq commented Dec 28, 2023

plugin-pb-go 1.15.0 now uses --license when invoking plugins, if one is set by the cli.

@disq disq requested a review from erezrokah December 28, 2023 20:26
@erezrokah
Copy link
Member

Same as cloudquery/plugin-sdk-python#101 (comment). We can add this when we decide to support it for JS plugins

src/plugin/serve.ts Outdated Show resolved Hide resolved
@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Dec 29, 2023
@kodiakhq kodiakhq bot merged commit 0537d45 into main Dec 29, 2023
7 checks passed
@kodiakhq kodiakhq bot deleted the fix/offline-licensing-placeholder branch December 29, 2023 10:59
kodiakhq bot pushed a commit that referenced this pull request Dec 29, 2023
🤖 I have created a release *beep* *boop*
---


## [0.1.1](v0.1.0...v0.1.1) (2023-12-29)


### Bug Fixes

* Add --license placeholder for future use ([#108](#108)) ([0537d45](0537d45))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to automerge PRs once requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants