Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add --license placeholder for future use #101

Merged
merged 1 commit into from
Dec 29, 2023
Merged

fix: Add --license placeholder for future use #101

merged 1 commit into from
Dec 29, 2023

Conversation

disq
Copy link
Member

@disq disq commented Dec 28, 2023 •
edited
Loading

plugin-pb-go 1.15.0 now uses --license when invoking plugins, if one is set by the cli.

@erezrokah
Copy link
Member

plugin-pb-go 1.15.0 now uses --license when invoking plugins, if one is set by the cli.

Will the CLI fail without this if the flag is passed? Maybe we don't need to add it at all for now

@erezrokah erezrokah mentioned this pull request Dec 28, 2023
Merged
@disq
Copy link
Member Author

disq commented Dec 28, 2023

Will the CLI fail without this if the flag is passed? Maybe we don't need to add it at all for now

@erezrokah yes, if somebody is mix-matching plugins and one of them is a non-Go one, it will also get the --license /path/to/file arguments as plugin-pb-go doesn't know which plugin is of which language.

@erezrokah
Copy link
Member

@erezrokah yes, if somebody is mix-matching plugins and one of them is a non-Go one, it will also get the --license /path/to/file arguments as plugin-pb-go doesn't know which plugin is of which language.

Can we make it that the Python SDK ignores unknown flags?

@disq
Copy link
Member Author

disq commented Dec 29, 2023

@erezrokah yes, if somebody is mix-matching plugins and one of them is a non-Go one, it will also get the --license /path/to/file arguments as plugin-pb-go doesn't know which plugin is of which language.

Can we make it that the Python SDK ignores unknown flags?

I don't know, I'll ask various AIs how to do that.

@erezrokah
Copy link
Member

I don't know, I'll ask various AIs how to do that.

No need let's just add it and be done with it

@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Dec 29, 2023
@kodiakhq kodiakhq bot merged commit 22d4c60 into main Dec 29, 2023
6 checks passed
@kodiakhq kodiakhq bot deleted the fix/offline-licensing-placeholder branch December 29, 2023 10:52
@cq-bot cq-bot mentioned this pull request Dec 29, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Dec 29, 2023
@cq-bot
chore(main): Release v0.1.10 (#102)
3fb00e4 
🤖 I have created a release *beep* *boop*
---


## [0.1.10](v0.1.9...v0.1.10) (2023-12-29)


### Bug Fixes

* Add --license placeholder for future use ([#101](#101)) ([22d4c60](22d4c60))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf

Assignees
No one assigned
Labels
automerge Add to automerge PRs once requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disq @erezrokah