fix: Fix toolbar feature flag detection to only apply in visual refresh mode #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
force-pushed
the
toolbar-flag
branch
from
1412471
to
fa5bac9
Compare
just-boris
commented
Aug 19, 2024
Comment on lines
+28
to
+30
| const page = new GlobalBreadcrumbsPage(browser); | ||
| await browser.url(url); | ||
| await page.waitForVisible(wrapper.findAppLayout().findContentRegion().toSelector()); |
There was a problem hiding this comment.
Extracted this repeating code while adding a new test
just-boris
commented
Aug 19, 2024
| import { isAppLayoutToolbarEnabled } from './utils/feature-flags'; | ||
| import { useAppLayoutToolbarEnabled } from './utils/feature-flags'; |
There was a problem hiding this comment.
Since I had to put useVisualRefresh hook, I had to convert this one as a hook too (but it should not count any performance impact, because we do not use any React hooks API internally anyway)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
==========================================
- Coverage 95.79% 95.79% -0.01%
==========================================
Files 741 741
Lines 20285 20293 +8
Branches 6898 6898
==========================================
+ Hits 19432 19439 +7
- Misses 797 798 +1
Partials 56 56 ☔ View full report in Codecov by Sentry. |
just-boris
force-pushed
the
toolbar-flag
branch
from
fa5bac9
to
59bcd77
Compare
dpitcock
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where some toolbar-only changes could leak into the classic design
Related links, issue #, if available: n/a
How has this been tested?
Added an integration test
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.