-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix toolbar feature flag detection to only apply in visual refresh mode #2584
Conversation
1412471
to
fa5bac9
Compare
const page = new GlobalBreadcrumbsPage(browser); | ||
await browser.url(url); | ||
await page.waitForVisible(wrapper.findAppLayout().findContentRegion().toSelector()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted this repeating code while adding a new test
import { isAppLayoutToolbarEnabled } from './utils/feature-flags'; | ||
import { useAppLayoutToolbarEnabled } from './utils/feature-flags'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I had to put useVisualRefresh
hook, I had to convert this one as a hook too (but it should not count any performance impact, because we do not use any React hooks API internally anyway)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
==========================================
- Coverage 95.79% 95.79% -0.01%
==========================================
Files 741 741
Lines 20285 20293 +8
Branches 6898 6898
==========================================
+ Hits 19432 19439 +7
- Misses 797 798 +1
Partials 56 56 ☔ View full report in Codecov by Sentry. |
fa5bac9
to
59bcd77
Compare
Description
Fixed a bug where some toolbar-only changes could leak into the classic design
Related links, issue #, if available: n/a
How has this been tested?
Added an integration test
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.