Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FileInput and FileTokenGroup #2846

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Conversation

katiegeorge
Copy link
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 90.36145% with 16 lines in your changes missing coverage. Please review.

Project coverage is 96.17%. Comparing base (35a8b43) to head (1552057).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/file-token-group/default-formatters.ts 64.28% 3 Missing and 2 partials ⚠️
src/file-input/internal.tsx 87.50% 4 Missing ⚠️
src/test-utils/dom/file-token-group/index.ts 85.71% 4 Missing ⚠️
src/file-token-group/file-token.tsx 85.71% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2846    +/-   ##
========================================
  Coverage   96.17%   96.17%            
========================================
  Files         759      767     +8     
  Lines       21364    21518   +154     
  Branches     7307     7341    +34     
========================================
+ Hits        20547    20696   +149     
- Misses        763      767     +4     
- Partials       54       55     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katiegeorge katiegeorge changed the title Kg/file deconstruction p1 feat: FileInput and FileTokenGroup Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant