Check go mod #102
Merged
Check go mod #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
force-pushed
the
check_gomod
branch
3 times, most recently
from
a6fd31c
to
daab6a1
Compare
shuheiktgw
force-pushed
the
check_gomod
branch
from
daab6a1
to
a5e8fe2
Compare
kazegusuri
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that "go mod tidy" generated some diffs, so I resolved them. To prevent the same problem happens again, I've added the "go_mod_check" job to the CI. Also, I've updated the minimum Go version for v1 to 1.18 to align it with v2.