[v2]change unsupported DDL behavior #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazegusuri
reviewed
Feb 13, 2024
v2/loader/schema_parser_source.go
Outdated
| @@ -58,13 +59,16 @@ func NewSchemaParserSource(fpath string) (SchemaSource, error) { | |||
| v := tables[tableName] | |||
| v.createIndexes = append(v.createIndexes, val) | |||
| tables[tableName] = v | |||
| case *spansql.CreateChangeStream: | |||
| log.Printf("skipped. CreateChangeStream isn't supported yet. got ' %s'", ddlstmt.SQL()) | |||
There was a problem hiding this comment.
Please remove this line. (If we do this, it's better to implement warning and it should output to stderr)
kazegusuri
reviewed
Feb 13, 2024
v2/loader/schema_parser_source.go
Outdated
| default: | ||
| return nil, fmt.Errorf("stmt should be CreateTable, CreateIndex or AlterTableAddForeignKey, but got '%s'", ddlstmt.SQL()) | ||
| return nil, fmt.Errorf("stmt should be CreateTable, CreateIndex, CreateChangeStream or AlterTableAddForeignKey, but got '%s'", ddlstmt.SQL()) |
There was a problem hiding this comment.
It's difficult to manage all expected key words here. Please change like this.
fmt.Errorf("unknown statement is specified: %s", ddlstmt.SQL())
kazegusuri
reviewed
Feb 13, 2024
v2/loader/schema_parser_source.go
Outdated
| case *spansql.AlterTable: | ||
| if isAlterTableAddFK(val) { | ||
| continue | ||
| } | ||
| return nil, fmt.Errorf("stmt should be CreateTable, CreateIndex or AlterTableAddForeignKey, but got '%s'", ddlstmt.SQL()) | ||
| return nil, fmt.Errorf("stmt should be CreateTable, CreateIndex, CreateChangeStream or AlterTableAddForeignKey, but got '%s'", ddlstmt.SQL()) |
There was a problem hiding this comment.
fmt.Errorf("unknown statement in AlterTable is specified: %s", ddlstmt.SQL())
nktks
changed the title
kazegusuri
approved these changes
Feb 13, 2024
|
Thanks for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to skip when schema file includes
CREATE CHANGE STREAMstatements in v2.Instead of #116 ,
I change code to skip when schema file includes statement which can parse and unsupported in yo v2 as v1 do.