Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pluralize to funcs (fix #51) #52

Merged

Conversation

S-YOU
Copy link
Contributor

@S-YOU S-YOU commented Sep 7, 2020

No description provided.

@S-YOU S-YOU changed the title add pluralize to funcs fix #51 add pluralize to funcs (fix #51) Sep 7, 2020
@S-YOU
Copy link
Contributor Author

S-YOU commented Sep 7, 2020

I am not very confident about this is the correct way to implement. Please take a look when you have time @kazegusuri
Thanks.

generator/funcs.go Outdated Show resolved Hide resolved
@kazegusuri
Copy link
Collaborator

LGTM. could you squash the commits?

@S-YOU
Copy link
Contributor Author

S-YOU commented Sep 8, 2020

LGTM. could you squash the commits?

Sure, done. Thanks @kazegusuri

@kazegusuri kazegusuri merged commit 10083d3 into cloudspannerecosystem:master Sep 8, 2020
@S-YOU S-YOU deleted the add-pluralize-to-funcs branch September 8, 2020 09:06
@S-YOU
Copy link
Contributor Author

S-YOU commented Sep 30, 2020

It's been a while. Could you please release new version with this? @kazegusuri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants