Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove goimports binary dependency #54

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Remove goimports binary dependency #54

merged 4 commits into from
Dec 9, 2020

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Dec 5, 2020 •
edited
Loading

WHAT

Remove goimports binary dependency.

WHY

Now forced to install the goimports binary to use yo, so change the formatting way using the golang.org/x/imports package.

Note

I'd already tested in our internal project. no diff.

@zchee
Copy link
Contributor Author

zchee commented Dec 5, 2020

/cc @kazegusuri

@zchee zchee force-pushed the remove-goimports-dependency branch from bcac1b0 to 5b4b1bd Compare December 5, 2020 19:17
@kazegusuri kazegusuri merged commit 52123fd into cloudspannerecosystem:master Dec 9, 2020
@zchee zchee deleted the remove-goimports-dependency branch December 9, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazegusuri kazegusuri kazegusuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zchee @kazegusuri