[v2] Ignore alter table statement to add foreign key in schema file #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema may contain alter table statement to add foreign key.
tyamagu2
changed the title
tyamagu2
changed the title
kazegusuri
approved these changes
Jul 22, 2021
I didn't know that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore alter table add foreign key statement when parsing schema file.
Spanner schema may contain alter table statements to add foreign keys.
For example, GetDatabaseDdl of spanner admin API seems to return such statement
when table A has a foreign key that references table B and B's name comes later in alphabetical order than A.
Such statements should not prevent yo from generating go code.