Do not hardcode partition if region isn't

See aws-cloudformation/cfn-lint#1805
cloudtools · Mar 20, 2021 · 01466cf · 01466cf
1 parent b4e4008
commit 01466cf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/awacs/aws.py b/awacs/aws.py
@@ -56,7 +56,9 @@ def JSONrepr(self):
 class BaseARN(AWSHelperFn):
     def __init__(self, service, resource, region='', account=''):
         region_string = region.lower()
-        if region_string.startswith("cn-"):
+        if region == "${AWS::Region}":
+            aws_partition = "${AWS::Partition}"
+        elif region_string.startswith("cn-"):
             aws_partition = "aws-cn"
         elif region_string.startswith("us-gov"):
             aws_partition = "aws-us-gov"

diff --git a/tests/test_aws.py b/tests/test_aws.py
@@ -40,3 +40,9 @@ def test_gov(self):
         self.assertEqual(
             arn.JSONrepr(),
             "arn:aws-us-gov:service:us-gov-west-1:account:resource")
+
+    def test_dynamic(self):
+        arn = BaseARN("service", "resource", "${AWS::Region}", "account")
+        self.assertEqual(
+            arn.JSONrepr(),
+            "arn:${AWS::Partition}:service:${AWS::Region}:account:resource")