Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3Origin doesn't have a DomainName property #1272

Closed
axelpavageau opened this issue Jan 7, 2019 · 0 comments · Fixed by #1273
Closed

S3Origin doesn't have a DomainName property #1272

axelpavageau opened this issue Jan 7, 2019 · 0 comments · Fixed by #1273

Comments

@axelpavageau
Copy link
Contributor

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-s3originconfig.html doesn't list the DomainName property, but it was added as mandatory by #1235 , introducing a regression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding a S3OriginConfig object to distinguish between Distribution and StreamingDistribution properties
1 participant
@axelpavageau