Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates CloudFront with missing parameters and validators #1235

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Updates CloudFront with missing parameters and validators #1235

merged 1 commit into from
Jan 6, 2019

Conversation

stevengorrell
Copy link
Contributor

@stevengorrell stevengorrell commented Nov 27, 2018 •
edited
Loading

Files Changed

cloudfront.py
validators.py
examples/CloudFront_S3.py
tests/examples_output/CloudFront_S3.template

Summary

Adds missing parameters
Fixes incorrect Origin specification
Adds validators
Fixes #978

@markpeek markpeek merged commit 5b7e414 into cloudtools:master Jan 6, 2019
@markpeek
Copy link
Member

markpeek commented Jan 6, 2019

Thanks!

@axelpavageau axelpavageau mentioned this pull request Jan 7, 2019
Closed
@markpeek markpeek mentioned this pull request Jan 8, 2019
Merged
davemasino pushed a commit to davemasino/troposphere that referenced this pull request Oct 17, 2019
@stevengorrell
Updates CloudFront with missing parameters and validators (cloudtools…
db4ff02 
…#1235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs further review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevengorrell @markpeek