Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValueError when template limits are hit #732

Closed
apmclean opened this issue Jun 6, 2017 · 1 comment
Closed

Raise ValueError when template limits are hit #732

apmclean opened this issue Jun 6, 2017 · 1 comment

Comments

@apmclean
Copy link
Contributor

apmclean commented Jun 6, 2017

Currently support exists for maximum resources and maximum parameters to raise a ValueError.
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html

However there are limits for Outputs and Mappings that can be tracked the same way. This is much cleaner than having AWS reject the template.

Incoming pull request with test cases.
markpeek pushed a commit that referenced this issue Jun 6, 2017
@apmclean @markpeek
Raise ValueError for Outputs and Mappings - Fix Issue #732 (#733)
39ab2e7 
* Added test cases for testing maximum outputs and maximum mappings
* Added exceptions when Maximum Outputs >= 60 or Maximum Mappings >= 100
* Added MAX_ variables and cleaned up hard coded values for the four MAX_ test cases
@apmclean
Copy link
Contributor Author

apmclean commented Jun 6, 2017

Fixed.

@apmclean apmclean closed this as completed Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apmclean