Fix mappings #1041
Merged
Fix mappings #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lrascao thanks for the PR, the code looks good - I'm a little worried that this is a change in behavior which might be used by other users of troposphere (the code for add_mapping is quite old, so there's a decent chance that someone is doing so). Also the term |
|
I made the tests check the json output, if you try and revert the fix you'll see that the |
|
ping? |
|
bump |
phobologic
approved these changes
Oct 11, 2019
|
Thanks! Sorry for the delay. |
davemasino
pushed a commit
to davemasino/troposphere
that referenced
this pull request
Oct 17, 2019
* Fix multiple mappings being overwritten * Add test coverage on multiple template mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple
template.add_mappingcalls were squashing the previous key, this patch fixes that