-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ForwardConfig in Listener #1555
Conversation
@markpeek Will you be able to review this please? |
I do not see this supported in CloudFormation yet. Thank you for the PR and I will verify/merge after AWS implements it. |
Thanks @markpeek AWS API documentation has details about ForwardConfig and I have tested that CFN template for Listener with ForwardConfig work perfectly. However, I agree to you and I have asked AWS to update the documentation. Will update this thread accordingly. |
Thanks @yks0000 for this update, this is something very useful for one of the projects I'm working on. @markpeek I think the document you shared has a mention of using ForwardConfig: "TargetGroupArn I think the documentation still needs to be properly updated but looks like a quick fix from AWS for now. |
AWS has opened a issue here to track it publicly |
CloudFormation just updated their documentation to include ForwardConfig. Very excited about this! |
I have tested this PR as well and it works great, very excited to see it merged soon. |
Thanks! Appreciate the wait for it to be supported. I'm going to follow up with a couple of adjustments. |
- Per resource spec: s/WeightedTargetGroups/TargetGroupTuple/ - Alphebetize and add trailing commas - Tweak an if statement for readability
For Issue: #1554