Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ForwardConfig in Listener #1555

Merged
merged 3 commits into from
Mar 15, 2020
Merged

Added support for ForwardConfig in Listener #1555

merged 3 commits into from
Mar 15, 2020

Conversation

yks0000
Copy link
Contributor

@yks0000 yks0000 commented Jan 8, 2020

For Issue: #1554

@yks0000
Copy link
Contributor Author

yks0000 commented Jan 10, 2020

@markpeek Will you be able to review this please?

@markpeek
Copy link
Member

I do not see this supported in CloudFormation yet. Thank you for the PR and I will verify/merge after AWS implements it.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-listener-defaultactions.html

@yks0000
Copy link
Contributor Author

yks0000 commented Jan 10, 2020

Thanks @markpeek AWS API documentation has details about ForwardConfig and I have tested that CFN template for Listener with ForwardConfig work perfectly.

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-listeners.html#forward-actions

However, I agree to you and I have asked AWS to update the documentation. Will update this thread accordingly.

@parvez99
Copy link

Thanks @yks0000 for this update, this is something very useful for one of the projects I'm working on.

@markpeek I think the document you shared has a mention of using ForwardConfig:

"TargetGroupArn
The Amazon Resource Name (ARN) of the target group. Specify only when Type is forward and you want to route to a single target group. To route to one or more target groups, use ForwardConfig instead. "

I think the documentation still needs to be properly updated but looks like a quick fix from AWS for now.

@yks0000
Copy link
Contributor Author

yks0000 commented Jan 17, 2020

AWS has opened a issue here to track it publicly

@helloangely
Copy link

CloudFormation just updated their documentation to include ForwardConfig. Very excited about this!

Docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-listener-forwardconfig.html

@aaronkvanmeerten
Copy link

I have tested this PR as well and it works great, very excited to see it merged soon.

@markpeek markpeek merged commit e2a2497 into cloudtools:master Mar 15, 2020
@markpeek
Copy link
Member

Thanks! Appreciate the wait for it to be supported. I'm going to follow up with a couple of adjustments.

markpeek added a commit that referenced this pull request Mar 15, 2020
- Per resource spec: s/WeightedTargetGroups/TargetGroupTuple/
- Alphebetize and add trailing commas
- Tweak an if statement for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants