Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change PropertyMap in kinesisanalyticsv2 PropertyGroup to dict #1863

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

m-architek
Copy link
Contributor

This PR fixing bug in field definition of PropertyGroup in kinesisanalyticsv2 module.

Reference:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-kinesisanalyticsv2-application-propertygroup.html

CF type is Json, bu json_checker represents String with json content. Correct type in troposphere to represent CF Json type is dict.

For example, in code pipeline Action CF:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-stages-actions.html
Configuration field is of type Json, so in troposphere:
https://github.com/cloudtools/troposphere/blob/master/troposphere/codepipeline.py
field type is dict, what is correct.

I tested this change in my project using version from my fork and it works correctly.

@markpeek markpeek merged commit 30c64ab into cloudtools:master Mar 13, 2021
@markpeek
Copy link
Member

Thanks! I added a fix for the tests to pass as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants