Check that FIFO Queues end with .fifo #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a validate() method in sqs.py that checks that FIFO queues (*) have a QueueName parameter and (*) QueueName ends with '.fifo' as required by AWS: http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html
markpeek
reviewed
Jul 1, 2017
| @@ -34,6 +34,12 @@ class Queue(AWSObject): | |||
| 'VisibilityTimeout': (integer, False), | |||
| } | |||
|
|
|||
| def validate(self): | |||
| if self.properties.get('FifoQueue'): | |||
| if not self.properties.get('QueueName', '').endswith('.fifo'): | |||
There was a problem hiding this comment.
The docs indicate QueueName is not required. But this code would raise an error if FifoQueue was specified without QueueName.
There was a problem hiding this comment.
Strangely, that's the first thing I thought too when we started using this internally. But after testing, it turns out that if you specify FifoQueue, you have to specify a QueueName, and it has to end with .fifo. It's annoying, but CF isn't smart enough to understand it has to add .fifo, which isn't all that surprising after all this time of messing w/ CF :)
|
Thanks! |
markpeek
pushed a commit
that referenced
this pull request
Dec 2, 2017
Fix validation failure for fifo queues in the case that no QueueName is specified. Note that Cloudformation *does* now automatically give a QueueName ending with .fifo in this case, contrary to the comment on PR #757.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a validate() method in sqs.py that checks that FIFO queues
() have a QueueName parameter and () QueueName ends with '.fifo'
as required by AWS:
http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html