Ulimit's HardLimit and SoftLimit validator change #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ulimit's HardLimit and SoftLimit validator needs to be integer and not positive_integer. http://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#container_definition_limits For example memlock can be -1:-1 as required by: https://www.elastic.co/guide/en/elasticsearch/reference/5.4/docker.html#_notes_for_production_use_and_defaults
|
Relevant cloudformation doc indicating type is integer: |
markpeek
reviewed
Jul 13, 2017
troposphere/ecs.py
Outdated
| @@ -1,5 +1,5 @@ | |||
| from . import AWSObject, AWSProperty | |||
| from .validators import boolean, network_port, positive_integer | |||
| from .validators import boolean, network_port, positive_integer, integer | |||
There was a problem hiding this comment.
Small change: can you alphabetize the imports? (put integer between boolean and network_port)
alphabetize the imports as per code review
|
Thank you for the change and the quick additional edit. |
dguinane
pushed a commit
to 7digital/troposphere
that referenced
this pull request
Jul 14, 2017
Ulimit's HardLimit and SoftLimit validator needs to be integer and not positive_integer. http://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#container_definition_limits For example memlock can be -1:-1 as required by: https://www.elastic.co/guide/en/elasticsearch/reference/5.4/docker.html#_notes_for_production_use_and_defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ulimit's HardLimit and SoftLimit validator needs to be integer and not positive_integer.
http://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#container_definition_limits
For example memlock can be -1:-1 as required by:
https://www.elastic.co/guide/en/elasticsearch/reference/5.4/docker.html#_notes_for_production_use_and_defaults