Update serverless.py #822
Merged
Update serverless.py #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "DefinitionBody" to serverless::api
|
See https://github.com/cloudtools/troposphere/blob/master/troposphere/ec2.py#L278 on how to perform an OR validation! |
|
As far as the type goes, can you test it yourself? Does CloudFormation expect an object, or a serialised object (string)? The main mention I can find says it's an 'object', not sure which one that actually is! https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessapi |
|
Thanks! I did push validation logic and some tests onto your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "DefinitionBody" to serverless::api. Not sure if this is the right type (dict) as the body can either be a YAML or JSON object. Also not sure how to do either/or (True/False) as you can specify either DefinitionBody or DefinitionUri. Would appreciate getting this added to the next release ASAP, as this is a blocking defect. Thanks!