Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResourceLifecycleConfig to ElasticBeanstalk #836

Merged
merged 3 commits into from
Oct 7, 2017
Merged

Add ResourceLifecycleConfig to ElasticBeanstalk #836

merged 3 commits into from
Oct 7, 2017

Conversation

gkrizek
Copy link
Contributor

@gkrizek gkrizek commented Oct 1, 2017 •
edited
Loading

Add the ResourceLifecycleConfig property to the AWS::ElasticBeanstalk::Application Class.

Closes #827

phobologic
phobologic requested changes Oct 1, 2017
View reviewed changes
Copy link
Member

@phobologic phobologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor naming changes to match the template specification. Thanks!

troposphere/elasticbeanstalk.py Outdated
@@ -26,6 +49,13 @@ class SourceConfiguration(AWSProperty):
}


class ResourceLifecycleConfig(AWSProperty):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this should be named ApplicationResourceLifecycleConfig

troposphere/elasticbeanstalk.py Outdated
}


class VersionLifecycleConfig(AWSProperty):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ApplicationVersionLifecycleConfig

@gkrizek
Copy link
Contributor Author

gkrizek commented Oct 1, 2017

@phobologic You are correct. My mistake!

Thanks for pointing that out. I'll update

@markpeek markpeek merged commit 60771df into cloudtools:master Oct 7, 2017
@markpeek
Copy link
Member

markpeek commented Oct 7, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phobologic phobologic phobologic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkrizek @markpeek @phobologic