Use the newly forked etcd client. #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new fork at github.com/cloudwan/etcd_for_gohan contains backported to v3.3.18 fix for etcd-io/etcd#9416 . We use watches heavily and with that fix, the memory usage in etcd server no longer grows uncontrollably. Regenerated go.sum while at it.
|
Note: the |
|
Note: here's the fork with backported fix that this PR references - https://github.com/cloudwan/etcd_for_gohan/tree/watchers_cancellation_v3.3.18 |
jkmar
approved these changes
Aug 24, 2020
yoichi-cloudwan
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new fork at github.com/cloudwan/etcd_for_gohan contains backported
to v3.3.18 fix for etcd-io/etcd#9416 . We
use watches heavily and with that fix, the memory usage in etcd server
no longer grows uncontrollably.
Regenerated go.sum while at it.