Skip to content

Commit

Permalink
feat: update to use node16 runner and bump ArgoCD default version 2.1.7
Browse files Browse the repository at this point in the history
  • Loading branch information
@bryantbiggs
bryantbiggs committed Dec 1, 2021
1 parent 9dc3b6f commit 9231f64
Show file tree
Hide file tree
Showing 6 changed files with 128 additions and 125 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = {
'plugin:prettier/recommended',
],
parserOptions: {
ecmaVersion: 2019,
ecmaVersion: 2020,
sourceType: 'module',
},
rules: {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16

- name: Release
env:
Expand Down
4 changes: 2 additions & 2 deletions action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ inputs:
description: >
Version of Argo CD to install - https://github.com/argoproj/argo-cd/releases
required: false
default: 2.1.3
default: 2.1.7

runs:
using: node12
using: node16
main: dist/index.js
5 changes: 1 addition & 4 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,14 @@
}
},
"resolutions": {
"ansi-regex": "^5.0.1",
"merge": ">=2.1.1",
"json-schema": ">=0.4.0"
"ansi-regex": "^5.0.1"
},
"dependencies": {
"@actions/core": "^1.6.0",
"@actions/exec": "^1.1.0",
"@actions/tool-cache": "^1.7.1",
"@octokit/auth-action": "^1.3.3",
"@octokit/rest": "^18.12.0",
"ansi-regex": "^6.0.1",
"string-argv": "^0.3.1"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "es2019",
"target": "es2020",
"moduleResolution": "node",
"skipLibCheck": true,
"removeComments": true,
Expand Down

3 comments on commit 9231f64

@644755
Copy link

@644755 644755 commented on 9231f64 Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is causing failure running workflows:
Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node16' is not supported, use 'docker' or 'node12' instead.')
at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load clowdhaus/argo-cd-action/main/action.yml

@bryantbiggs
Copy link
Member Author

@bryantbiggs bryantbiggs commented on 9231f64 Dec 1, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies @644755 - I don't know what is going on with the GitHub runner release version at the moment actions/runner#1439 (comment) which is causing this issue. the prior version works as intended still

@644755
Copy link

@644755 644755 commented on 9231f64 Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryantbiggs works indeed :) Thanks for your efforts.

Please sign in to comment.