Initial migration from ethers v4 to v5 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhcc
suggested changes
Aug 1, 2020
PumpkingWok
changed the title
xuhcc
approved these changes
Aug 3, 2020
|
@PumpkingWok This PR is marked as |
PumpkingWok
changed the title
|
Hi @xuhcc, |
daodesigner
pushed a commit
that referenced
this pull request
Sep 19, 2021
Adding getters and status to project card/page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have migrated
ethersfrom4.0.47to5.0.1and also all dependencies needed.I had to add a
try/catchblock when it callsparseLog(), it seems to retrieve an event outside of the contract.Look to this issue, i retrieved the same error -> ethers-io/ethers.js#733
Fixes: #80