feat(listbox): support form reset

clshortfuse · Oct 10, 2024 · 2de1313 · 2de1313
1 parent 7f03c31
commit 2de1313
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/components/Input.js b/components/Input.js
@@ -612,6 +612,7 @@ export default CustomElement
           // Unbind and release
           _listbox.removeEventListener('change', this._onListboxChangeListener);
           _listbox.removeEventListener('click', this._onListboxClickListener);
+          _listbox._handleFormReset = true;
         }
         this._listbox = listbox;
         if (listbox) {
@@ -620,6 +621,7 @@ export default CustomElement
             listbox.required = true; // Don't allow unclick
           }
 
+          _listbox._handleFormReset = false;
           listbox.addEventListener('change', this._onListboxChangeListener);
           listbox.addEventListener('click', this._onListboxChangeListener);
           this.populateInputFromListbox();

diff --git a/components/Listbox.js b/components/Listbox.js
@@ -25,6 +25,7 @@ export default List
     /** @type {HTMLCollectionOf<InstanceType<ListOption>>} */
     _selectedOptionsCollection: null,
     _handlingSelectedness: false,
+    _handleFormReset: true,
   })
   .define({
     options() {
@@ -103,7 +104,9 @@ export default List
       this.updateAriaProperty('ariaMultiSelectable', newValue ? 'true' : 'false');
     },
     _formResetChanged(oldValue, newValue) {
-      // TODO: Unset dirty
+      if (!newValue) return;
+      if (!this._handleFormReset) return;
+      this.value = this.defaultValue;
     },
     connected() {
       if (!this.hasAttribute('tabindex')) {