Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash with zero length location in object #7

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

n-peugnet
Copy link
Member

@n-peugnet n-peugnet commented Jan 13, 2024

Fix a crash when location have zero length, which can happen and add a regression test.

Found thanks to nikic/PHP-Fuzzer.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c29285) 100.00% compared to head (a236304) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main        #7   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        35        36    +1     
===========================================
  Files              4         4           
  Lines             98        98           
===========================================
  Hits              98        98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-peugnet n-peugnet merged commit 20efd37 into main Jan 13, 2024
11 checks passed
@n-peugnet n-peugnet deleted the fix-zerolength-location branch January 13, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant