Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression to dev environment to match production configuration #41

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Jun 18, 2024

This pull request improves the configuration for the dev environment by enabling HTTP compression (brotli and gzip). Our production system uses a content delivery network (CDN) which uses brotli compression by default with a possible fallback to gzip. Our current dev environment configuration doesn't allow compression, which will change through my suggestion and thus better aligns our production environment and our dev environment.

As a first step, I made sure that our production system works with the improved integration tests like this:

bash tests/integration.bash https://framework-x.org

Once the test suite confirmed my changes, I improved the dev configuration and ran the same tests against the new dev environment:

bash tests/integration.bash

This is also confirmed by our automated test suite (which uses dev environment), so I think this pull request is save to apply and will have no impact on the production system 👍

Builds on top of #40 and others.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this, changes LGTM! :shipit:

@clue clue merged commit c868fb2 into clue:main Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants