Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network api #57

Merged
merged 2 commits into from
Feb 8, 2020
Merged

Add network api #57

merged 2 commits into from
Feb 8, 2020

Conversation

thojou
Copy link
Contributor

@thojou thojou commented Feb 6, 2020

Hi!

Thanks for this great, easy to use package. In a project of mine, I required some interactions with the network API. I've integrated the related actions into the client.

Maybe you wanna review my changes and integrate them into your project.
Let me now, if you want me to adjust something.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjoussen Thank you for providing this high quality PR along with unit tests and a functional test!

Changes LGTM, now let's get this shipped! :shipit: Keep it up! 👍

@clue clue added this to the v1.1.0 milestone Feb 8, 2020
@clue clue merged commit 7cef83f into clue:master Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants