Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHPUnit 9 #18

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Run tests on PHPUnit 9 #18

merged 2 commits into from
Aug 13, 2020

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Aug 5, 2020

For further details concerning this pull request look into graphp/graphviz #46.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this! Only some minor remarks below

tests/TestCase.php Outdated Show resolved Hide resolved
tests/TestCase.php Outdated Show resolved Hide resolved
@SimonFrings SimonFrings force-pushed the tests branch 2 times, most recently from 50c2667 to d0c3782 Compare August 13, 2020 11:48
@clue clue added this to the v1.3.0 milestone Aug 13, 2020
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit e2e2763 into clue:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants