Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pub/Sub #24

Merged
merged 6 commits into from
Nov 12, 2014
Merged

Support Pub/Sub #24

merged 6 commits into from
Nov 12, 2014

Conversation

clue
Copy link
Owner

@clue clue commented Aug 26, 2014

Refs #2.

@clue clue added this to the v0.5.0 milestone Aug 26, 2014
@clue
Copy link
Owner Author

clue commented Oct 22, 2014

Reliably matching when an incoming message is actually a pubsub event and when it's a response to a query (MGET mostly) turns out to be harder to than expected.

Some other implementations take the simple route and just assume every response that looks like a pubsub message must be one, like then-redis.

See 2f0ba2e for a test case that would fail in this case.

@clue
Copy link
Owner Author

clue commented Nov 12, 2014

Reliably matching when an incoming message is actually a pubsub event and when it's a response to a query (MGET mostly) turns out to be harder to than expected.

Turns out things aren't really that complicated either.

The SUBSCRIBE and UNSUBSCRIBE commands support a variable number of arguments and return a non-standard answer when not using a single argument. However, their operation is quite simple when only considering single arguments. As a first step, we should focus on supporting this simple use case.

clue added 2 commits November 12, 2014 02:03
The (p)(un)subscribe commands only accept a single topic name for now.
@clue
Copy link
Owner Author

clue commented Nov 12, 2014

The error'ed travis build is being addressed by #25.

@clue clue changed the title [WIP] Support Pub/Sub Support Pub/Sub Nov 12, 2014
clue added a commit that referenced this pull request Nov 12, 2014
@clue clue merged commit 277b540 into master Nov 12, 2014
@clue clue deleted the pubsub branch November 12, 2014 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant