-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Pub/Sub #24
Support Pub/Sub #24
Conversation
Reliably matching when an incoming message is actually a pubsub event and when it's a response to a query (MGET mostly) turns out to be harder to than expected. Some other implementations take the simple route and just assume every response that looks like a pubsub message must be one, like then-redis. See 2f0ba2e for a test case that would fail in this case. |
Turns out things aren't really that complicated either. The SUBSCRIBE and UNSUBSCRIBE commands support a variable number of arguments and return a non-standard answer when not using a single argument. However, their operation is quite simple when only considering single arguments. As a first step, we should focus on supporting this simple use case. |
The (p)(un)subscribe commands only accept a single topic name for now.
The error'ed travis build is being addressed by #25. |
Refs #2.