Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git-bash use conemu-msys2-64 connector #2765

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

nexplorer-3e
Copy link
Contributor

@nexplorer-3e nexplorer-3e commented Oct 18, 2022

use conemu-msys2-64 connector would help to solve some display problems under Git Bash like

  • character drifting,
  • cursor wrong position,
  • tmux display wrong,
  • and so on.
    As the default profile is hardcoded and ConEmu upstream has solved it by using msys-connector, I copied from ConEmu default profile to use it.

…ctor

use conemu-msys2-64 connector would help to solve some display problems under Git Bash like character/cursor drifting, `tmux` display wrong, and so on. As the default profile is hardcoded and ConEmu upstream has solved it by using msys-connector, please add it.
@nexplorer-3e
Copy link
Contributor Author

Another thing about using conemu connector is xterm-256color. For example, as shown in ConEmu Docs, show real color of vim need to add -cur_console:h0 startup parameter to make it work. But turn BufferHeight off has other sides, for which I didn't add it.

@DRSDavidSoft
Copy link
Contributor

DRSDavidSoft commented Oct 19, 2022

@nexplorer-3e I merged the changes for additional testing in Cmder. Thanks for your contribution!

More information regarding this subject:

https://conemu.github.io/en/CygwinMsysConnector.html

@DRSDavidSoft DRSDavidSoft merged commit 98d2884 into cmderdev:master Oct 19, 2022
@daxgames
Copy link
Member

@DRSDavidSoft I generally try and test these out before merging to master as I assume you did, and you just wanted a second set of eyes on it. Seems to work fine.

I never experienced any of the issues it is supposed to fix so I see no difference in how it works so not completely clear on the benefits other than @Maximus5 always brings up the connector when any display issues are mentioned in ConEmu issues. This will help with Cmder bash and those situations.

One note this change only affects new installs of Cmder and existing users will need to update their bash tasks as follows in the Conemu GUI:

  1. bash::bash
    a. Update "%ConEmuDir%\..\git-for-windows\usr\bin\bash.exe"; --login -i
    b. To set "PATH=%ConEmuDir%\..\git-for-windows\usr\bin;%PATH%" & %ConEmuDir%\..\git-for-windows\git-cmd.exe --no-cd --command=%ConEmuBaseDirShort%\conemu-msys2-64.exe "%ConEmuDir%\..\git-for-windows\usr\bin\bash.exe" --login -i
  2. bash::bash as Admin
    a. Update *"%ConEmuDir%\..\git-for-windows\usr\bin\bash.exe"; --login -i
    b. To *set "PATH=%ConEmuDir%\..\git-for-windows\usr\bin;%PATH%" & %ConEmuDir%\..\git-for-windows\git-cmd.exe --no-cd --command=%ConEmuBaseDirShort%\conemu-msys2-64.exe "%ConEmuDir%\..\git-for-windows\usr\bin\bash.exe" --login -i

@DRSDavidSoft
Copy link
Contributor

Thanks, as you said I tested (only for potential issues) and didn't notice any problems, however as you said I didn't notice these problems either. Since this change was introduced in upstream, I believe using ConEmu connectors hopefully won't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants