Improves performance of prompt filtering #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements custom logic to detect if we're inside of working tree and skips os calls if not. This will improve performance of prompt handling, especially for mercurial prompt.
When `get_git_status` fails the inner `os.execute` call print error message to console. This removes all error messages fro such cases.
MartiUK
added a commit
that referenced
this pull request
Mar 22, 2015
Improves performance of prompt filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dramatically improves performance of promp filtering for git and mercurial by using custom logic to pre-check if process calls is necessary. The overal
clink.prompt_filterexecution time is decreased from ~600 ms to: