-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batch files #698
Fix batch files #698
Conversation
@@ -1,3 +1,3 @@ | |||
@echo off | |||
SET CMDER_ROOT=%~dp0 | |||
start %~dp0/vendor/conemu-maximus5/ConEmu.exe /Icon "%CMDER_ROOT%\icons\cmder.ico" /Title Cmder /LoadCfgFile "%CMDER_ROOT%\config\ConEmu.xml" | |||
start %~dp0/vendor/conemu-maximus5/ConEmu.exe /Icon "%CMDER_ROOT%icons\cmder.ico" /Title Cmder /LoadCfgFile "%CMDER_ROOT%config\ConEmu.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an oversight: the normal launcher does not use /LoadCfgFile anymore
I am also working on enabling the use of the new git bash. Should be ready soon |
It will be a separate pull request though |
I don't even know if we want to keep the bat around, it's only used for Windows XP anyway, no? |
It is in the source so i fixed it. Do with it whatever you feel is necessary. |
I think it looks weird without the |
It might look wierd but it is correct. It looks even wierder when you look at the %path% or a variable that has On November 12, 2015 6:54:47 AM Benjamin Staneck notifications@github.com
|
Well actually it might be the better way to just remove the |
We could do that to get rid of the wierdness. That would also require changes to my other pull request as it behaves in a manner consistent with what init.bat does and expects %CMDER_ROOT% and $CMDER_ROOT both end with either a '' or '/'. I can work on both to correct. |
I would prefer dropping the slash from the variable. @cmderdev/trusted-contributors @cmderdev/owners any objections to changing the root variable to drop the slash like that? Also @daxgames can we leave daxgames@e56e006 out of this PR, I don |
ebef0f7
to
184344c
Compare
I actually modified the .gitignore in my last commit so it is relevant to all and does not contain any personal files. I only added the config/user-* files that are auto created by launching shells in this build. If you still feel it should be left out then leave it out. |
Nope, that's good. Can you squash please? |
184344c
to
fc1f792
Compare
Squashed |
hang on something got messed up in the squash let me fix it. |
fc1f792
to
eb5ab51
Compare
Squash fixed. One commit 3 files changed. Sorry about that somehow I combined two branches. in the previous squash |
Great, thank you! |
Replaced %CMDER_ROOT%\ with %CMDER_ROOT% because the variable already ends with \