Revert "Set CMDER_START to homeprofile" #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 728e83a. The problem with *always* setting CMDER_START is that this makes the `-new_console:d:%USERPROFILE%` in the conemu task definitions unnecessary, as this is now always overwritten as CMDER_START is set. This also means that a very visible conemu UI for setting the startup dir does not work anymore which might leave the user puzzled why.
MartiUK
added a commit
that referenced
this pull request
Mar 10, 2016
Revert "Set CMDER_START to homeprofile"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is more or less to have a easier way to discuss the issue...
This reverts commit 728e83a.
The problem with always setting CMDER_START is that this makes the
-new_console:d:%USERPROFILE%in the conemu task definitions unnecessary, as this is now always overwritten as CMDER_START is set. This also means that a very visible conemu UI for setting the startup dir does not work anymore (try opening a cmder windows when the default task has a-new_console:d:c:\temp) which might leave the user puzzled.So: what is the use case for always setting the variable and if that's important: why not set it in the startup scripts after they have checked where to start up?