Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#164] Update HTTPSOptions to make it compatible with Deno 1.20.1 #165

Merged
merged 4 commits into from
Mar 20, 2022

Conversation

AEtheve
Copy link
Contributor

@AEtheve AEtheve commented Mar 20, 2022

Issue

Fixes #164.

Details

I just adjusted the httpsOptions type of opine so that the key and cert keys are non-optional.

CheckList

  • PR starts with [#ISSUE_ID].
  • Has been tested (where required).

@AEtheve AEtheve changed the title Update HTTPSOptions to make it compatible with Deno 1.20.1 [#164] Update HTTPSOptions to make it compatible with Deno 1.20.1 Mar 20, 2022
@github-actions
Copy link

github-actions bot commented Mar 20, 2022

Benchmark results

PR to merge main df7f4bb -> main
opine: 1 middleware
================================

1 middleware
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.22ms  654.58us  19.67ms   88.79%
    Req/Sec     2.27k   304.52     2.65k    79.69%
  Latency Distribution
     50%    2.05ms
     75%    2.33ms
     90%    2.78ms
     99%    4.29ms
  14462 requests in 3.21s, 2.61MB read
Requests/sec:   4510.42
Transfer/sec:    832.49KB

opine: 10 middleware
================================

10 middleware
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.26ms  710.07us  21.29ms   90.07%
    Req/Sec     2.23k   330.35     2.55k    81.25%
  Latency Distribution
     50%    2.06ms
     75%    2.38ms
     90%    2.83ms
     99%    4.44ms
  14244 requests in 3.21s, 2.57MB read
Requests/sec:   4443.38
Transfer/sec:    820.12KB

opine: 50 middleware
================================

50 middleware
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.55ms  788.64us  21.72ms   87.70%
    Req/Sec     1.97k   258.64     2.25k    79.03%
  Latency Distribution
     50%    2.42ms
     75%    2.79ms
     90%    3.23ms
     99%    4.73ms
  12189 requests in 3.11s, 2.20MB read
Requests/sec:   3914.28
Transfer/sec:    722.46KB

std/http benchmark
================================

Server listening on localhost:3333
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   614.26us  177.45us   5.05ms   92.64%
    Req/Sec     8.01k   791.81     8.69k    87.50%
  Latency Distribution
     50%  584.00us
     75%  627.00us
     90%  723.00us
     99%    1.15ms
  51016 requests in 3.20s, 4.23MB read
Requests/sec:  15941.65
Transfer/sec:      1.32MB

deno_http_native benchmark
================================

Server listening on localhost:3333
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   653.68us  209.38us   5.10ms   90.04%
    Req/Sec     7.52k     0.94k    8.72k    67.19%
  Latency Distribution
     50%  597.00us
     75%  683.00us
     90%  844.00us
     99%    1.42ms
  47902 requests in 3.20s, 3.97MB read
Requests/sec:  14966.82
Transfer/sec:      1.24MB

@cmorten
Copy link
Owner

cmorten commented Mar 20, 2022

See CI for formatting / linting issues

@AEtheve
Copy link
Contributor Author

AEtheve commented Mar 20, 2022

See CI for formatting / linting issues
Now this should do it

@cmorten cmorten merged commit 44c53a2 into cmorten:main Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type incompatibility with Deno 1.20.1
2 participants