Adds 2D plotting script PostFit2DShapesFromWorkspace.cpp #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Lucas, thanks for the PR. It's useful to know that there's demand for 2D shape evaluation in CH. I'm a little hesitant to merge this straightaway since it duplicates a lot of existing code, which makes things harder to maintain in the future. We've been planning to significantly rework CH under the hood this year anyway, so it might be better if we take this into account while we're doing that. Is that ok for you? |
|
Hi Andrew, I certainly agree about the duplication of existing code. I mainly wanted to bring this forward since I'm the only one who's looked at it but I think having 2D shapes in one form or another would be beneficial to others as well. I'm happy to wait for the rework. Thanks for looking at it! |
Update with official changes
to match 1D version from update of official release
Add ability for RooParametricHist templates
Update this fork with central repo changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2D plotting script PostFit2DShapesFromWorkspace.cpp and supporting infrastructure to go with the addition of a RooParametricHist2D class which has a PR here [1] with a full description.
[1] - cms-analysis/HiggsAnalysis-CombinedLimit#545