Fixup recipe for LCG-based standalone environment #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kcormi @anigamova I think this can be merged? |
|
Thanks @nsmith- , I just had one very minor comment. Otherwise it looks fine to merge from my side. |
kcormi
reviewed
Jun 30, 2023
docs/index.md
Outdated
| LCG102 contains ROOT 6.26, which at the time of writing is not available in any CMSSW release. | ||
| This repo can be compiled against LCG102 with: | ||
| ``` | ||
| LCG102 and above contains ROOT 6.26, which at the time of writing is not available in any CMSSW release. |
There was a problem hiding this comment.
Very minor, I wonder if we might want to just change this line, to help future proof it from becoming out-of-date or misleading.
maybe something like:
For compilation outside of CMSSW, for example to use ROOT versions not yet available in CMSSW, one can compile against LCG releases. The current default is to compile with LCG_102 which contains ROOT 6.26.
There was a problem hiding this comment.
Thanks, that's a good suggestion
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the headers missed the relative path treatment as done in #793.
@guitargeek FYI for #790 this changes
classes.hin what I think is an identical manner. By the way, do you know what I could change in thegenreflexcommand to not have to package these headers, if possible?