Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in shapeN + CMSHistFunc/Sum #995

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ajgilbert
Copy link
Collaborator

  • Fixes major bug when using --X-rtd FAST_VERTICAL_MORPH in conjunction with CMSHistSum where the log value of the templates were applied in every evaluate, not just the first time
  • Fix minor bug in CMSHistFunc and CMSHistSum which now explicitly fixes the normalization after shapeN interpolation to the nominal

@anigamova anigamova merged commit 84c2bae into cms-analysis:main Jul 23, 2024
8 checks passed
@nsmith-
Copy link
Collaborator

nsmith- commented Sep 3, 2024

In principle we could now require the test https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/actions/runs/10043200902/job/27755411724#step:6:475 to succeed:

Out of 10 toys, {'kl': 0, 'kv': 0, 'k2v': 0} are not matching (tolerance: 1e-4) between CMSHistFunc and CMSHistSum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants