Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fb-package] Fix failing contingency CI due to readr version change #1129

Merged
merged 4 commits into from
Jul 21, 2021

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jul 20, 2021

Description

Prevent survey CI from updating to new major release of readr. A couple bugs (apparently spurious compilation errors on install and failure to write empty files) cause test failures. I've filed issues and hopefully those are fixed in the next minor version; will keep an eye on future readr releases.

Changelog

  • Remove path argname. Argument will by default use the new file arg.
  • Exclude readr from being updated in Actions workflow.

@nmdefries nmdefries force-pushed the contingency-write-csv-path-fix branch from bb467d4 to 4ba5467 Compare July 20, 2021 20:02
@nmdefries nmdefries changed the title [fb-package] Fix failing contingency test [fb-package] Fix failing contingency CI due to readr version change Jul 20, 2021
@chinandrew
Copy link
Contributor

Just so I understand, does the cache in CI not have the new major version yet, since I don't see a pinned version anywhere? If so, how did that happen if it's currently set to always update? Certainly there was some CI run in the last day that would've triggered it.

@nmdefries
Copy link
Contributor Author

does the cache in CI not have the new major version yet

Nope, the cache has the old version of readr (1.4.0). A new version of the cache is only saved once a month (more on this below). When the cache is loaded, any packages in it that are out of date are updated to their newest versions. However, those updates only apply to the current run. Once a cache with a given name (key) is created, it can't be overwritten, so package updates aren't saved anywhere.

For clarity, I'll explicitly install the 1.4.0 version.

On monthly caching: thinking about it more, it makes more sense to move this to daily versioning. I was initially trying to minimize the number of times we would have to run the full install process (since it takes a long time), but with restore keys cache updates are incremental. I'll make a separate PR for that.

@nmdefries nmdefries marked this pull request as draft July 20, 2021 22:32
@nmdefries nmdefries marked this pull request as ready for review July 20, 2021 22:46
Copy link
Contributor

@chinandrew chinandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit:

@krivard krivard merged commit 22dc189 into main Jul 21, 2021
@krivard krivard deleted the contingency-write-csv-path-fix branch July 21, 2021 14:07
@krivard krivard mentioned this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants