Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update oidc and silent-renew #114

Merged
merged 4 commits into from
Mar 20, 2023
Merged

update oidc and silent-renew #114

merged 4 commits into from
Mar 20, 2023

Conversation

sei-jmattson
Copy link
Collaborator

@sei-jmattson sei-jmattson commented Mar 20, 2023

Updated oidc dependency and fix silent-renew.

Recommended oidc settings:

oidc: {
  client_id: 'dev-code',
  authority: 'http://localhost:5000',
  redirect_uri: 'http://localhost:4200/oidc',
  silent_redirect_uri: 'http://localhost:4200/assets/oidc-silent.html',
  response_type: 'code',
  scope: 'openid profile dev-api',
  loadUserInfo: true,    // generally needed for our apps since we don't really use an id_token
  useLocalStorage: true, // true means auth_token is used browser-wide; false means each tab has to get a token
}

Additional settings: https://authts.github.io/oidc-client-ts/interfaces/UserManagerSettings.html

Copy link
Contributor

@sei-bstein sei-bstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work on this - makes my life a lot easier!

@sei-bstein sei-bstein changed the base branch from main to next March 20, 2023 15:29
@sei-bstein
Copy link
Contributor

Resolves Gameboard API #134.

@sei-bstein sei-bstein merged commit ad1f13f into next Mar 20, 2023
@sei-bstein sei-bstein deleted the fix-auth-silent-renew branch March 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants